Feature/wfx200 wifi driver #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This driver currently presents itself as a ethernet device. Joining a WiFi hotspot is possible by configuring SSID and PSK in Kconfig. Currently only SPI is supported. Origin: Original Signed-off-by: Ruben Völl <[email protected]>
The wifi_mgmt device callbacks structure has been altered to allow for non-offloaded ip stacks. This has been done in a way to be api compatible. This also adds a event task to interact with with theL2 stack. The driver now supports using the hif(host interface selection) pin to select the used interface(only SPI supported). Also sleep, but without connection to the zephyr PM, has been implemented. Origin: Original Signed-off-by: Ruben Völl <[email protected]>
Changed the behavior of the driver that it acts in AP oder Station mode depending on which mode has been selected first. Added a state enumeration to keep track of which mode has been selected. Origin: Original Signed-off-by: Ruben Völl <[email protected]>
This implements the get_capabilities function to be on the safe side. The wfx200 variant of this function just retuns 0, as it does not provide any ethenernet capabilities. Origin: Original Signed-off-by: Ruben Völl <[email protected]>
Use a own heap instead of relying on the kernel heap. Origin: Original Signed-off-by: Ruben Völl <[email protected]>
Call directly public function from netilion application to get the firmware. This patch should NOT BE commited to zephyr and is used as a temporary solution to be able to use that driver. On a later step callback mechanism has to be implemented.
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
|
Also getting: net_mgmt: Event info length 48 > max size 36 |
allopatin
suggested changes
Sep 27, 2021
| */ | ||
| sl_status_t sl_wfx_host_init(void) | ||
| { | ||
| OnFirmwareInit(); |
There was a problem hiding this comment.
Why not use the callback structures @NilsRuf-EH created for our driver? The solution here seems to add cross dependancy. Also with OnFirmwareChunkRequested and OnFirmwareSizeRequested. It would be prefered if this driver implementation could be added into Zephyrs main repo. I doubt it will be possible in the current state.
|
|
||
| config WIFI_WFX200_BUS_SPI | ||
| bool "SPI Bus interface" | ||
| select SPI |
There was a problem hiding this comment.
I do not think these are necessary as they should be set by the device tree.
| struct net_if_api iface_api; | ||
| union { | ||
| struct net_if_api iface_api; | ||
| struct ethernet_api eth_api; |
There was a problem hiding this comment.
Changes like in PR for the Zephyr repo would be appreciated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.