Throw more specific error in response interceptor #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calls to storage where the field doesn't exist return an array with a single null element. That throws an error when trying to access .type
Instead throw an error with a hopefully more helpful message.
ryanflynndev
previously approved these changes
Apr 21, 2025
JustWalters
changed the title
I'd been more generic because I don't know when else this happens, but this should always be accurate. Then the update to the latest SDK version becomes confusing IMO.
Zmatarasso
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls to storage where the field doesn't exist return an array with a single null element. That causes an error when trying to access .type
I think this is a bug fix, but please let me know if it's not, or it's a breaking change a la
Update: Confirmed there are places we rely on this behavior, so instead of not throwing, we'll throw a more informative error. And opened #76 to avoid the error in the next major version.