fix: var() with fallback value in no-invalid-properties
#184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumirlumir
added
the
accepted
nzakas
reviewed
Jul 1, 2025
| @@ -37,6 +37,23 @@ ruleTester.run("no-invalid-properties", rule, { | |||
| ":root { --my-color: red; }\na { color: var( --my-color ) }", | |||
| ":root { --my-color: red;\n.foo { color: var(--my-color) }\n}", | |||
| ".fluidHeading {font-size: clamp(2.1rem, calc(7.2vw - 0.2rem), 2.5rem);}", | |||
| "a { color: var(--my-color, red) }", | |||
There was a problem hiding this comment.
Can you add some invalid tests that use fallbacks with incorrect or missing values? Based on the code changes in this PR, I think the error locations will be off.
There was a problem hiding this comment.
Seems you are right, I think it still needs some work, like multiple var in the property and this, so marking it as draft for now. Thanks!
There was a problem hiding this comment.
Have updated the code to fix this and added some tests as well?
nzakas
approved these changes
Jul 7, 2025
|
@Tanujkanti4441 There are few ci failures, can you please check once? |
|
The failures have already been fixed on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
To fix the lining errors while using
var()with fallback values.What changes did you make? (Give an overview)
Added a function to remove fallbacks when the variable value is present and a function to get a list of fallback values to use it, when there is no reference present of the variable.
So these cases are the valid:
Related Issues
fixes #180
Is there anything you'd like reviewers to focus on?