Report number of reorder_seen #1278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuba-moo
force-pushed
the
report-reorder
branch
from
8b3a23f to
7146bbf
Compare
|
Can you please rebase this to the latest upstream master? |
|
@bmah888 any thoughts on merging this? We've been constantly recreating this change in the Fedora package for a while now. Would be great to see it merged to save us the work on new updates. |
|
@bmah888 can you take a look? |
bmah888
reviewed
May 22, 2025
src/iperf_api.c
Outdated
| @@ -3753,7 +3755,7 @@ iperf_print_results(struct iperf_test *test) | |||
| if (test->sender_has_retransmits) { | |||
| /* Sender summary, TCP and SCTP with retransmits. */ | |||
| if (test->json_output) | |||
| cJSON_AddItemToObject(json_summary_stream, report_sender, iperf_json_printf("socket: %d start: %f end: %f seconds: %f bytes: %d bits_per_second: %f retransmits: %d max_snd_cwnd: %d max_snd_wnd: %d max_rtt: %d min_rtt: %d mean_rtt: %d sender: %b", (int64_t) sp->socket, (double) start_time, (double) sender_time, (double) sender_time, (int64_t) bytes_sent, bandwidth * 8, (int64_t) sp->result->stream_retrans, (int64_t) sp->result->stream_max_snd_cwnd, (int64_t) sp->result->stream_max_snd_wnd, (int64_t) sp->result->stream_max_rtt, (int64_t) sp->result->stream_min_rtt, (int64_t) ((sp->result->stream_count_rtt == 0) ? 0 : sp->result->stream_sum_rtt / sp->result->stream_count_rtt), stream_must_be_sender)); | |||
| cJSON_AddItemToObject(json_summary_stream, "sender", iperf_json_printf("socket: %d start: %f end: %f seconds: %f bytes: %d bits_per_second: %f retransmits: %d reorder: %d max_snd_cwnd: %d max_snd_wnd: %d max_rtt: %d min_rtt: %d mean_rtt: %d sender: %b", (int64_t) sp->socket, (double) start_time, (double) sender_time, (double) sender_time, (int64_t) bytes_sent, bandwidth * 8, (int64_t) sp->result->stream_retrans, (int64_t) sp->result->stream_reorder, (int64_t) sp->result->stream_max_snd_cwnd, (int64_t) sp->result->stream_max_snd_wnd, (int64_t) sp->result->stream_max_rtt, (int64_t) sp->result->stream_min_rtt, (int64_t) ((sp->result->stream_count_rtt == 0) ? 0 : sp->result->stream_sum_rtt / sp->result->stream_count_rtt), stream_must_be_sender)); | |||
There was a problem hiding this comment.
This line changes report_sender to the literal "sender" (in addition to the two other changes related to this feature). Can it not do that? I realize it's possible that this might be due to code changes during the long time that elapsed since the original PR submission.
There was a problem hiding this comment.
Yes, I think that's unrelated. I rebased my patch and it went away.
kuba-moo
force-pushed
the
report-reorder
branch
2 times, most recently
from
c11a596 to
ed72662
Compare
TCP can detect reordering by tracking SACKs and timestamps coming back to the sender. This is useful information for investigating performance issues and testing networks as good networks should generally not reorder packets.
bmah888
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version of iperf3: master
Brief description of code changes (suitable for use as a commit message):
Report reorder_seen Linux TCP statistic in the detailed (JSON) output.