-
Notifications
You must be signed in to change notification settings - Fork 318
Revise website tutorial how-to-transactional-write #1025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Revise website tutorial how-to-transactional-write #1025
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wendy-ha18 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @wendy-ha18. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
41f20f7
to
b316d0b
Compare
One requirement of issue: #801 mentioned about After consideration, IMHO, the main reason we want to transactionally write things are to maintain data consistency and ensure expected state fefore writing, which are similar with this part. Just want to ask maintainer @jmhbnz do you have any opinions on it?. Do we still need to including this explaination to make the tutorial clearer? |
cc @ronaldngounou @jberkus @nate-double-u for reviewing. |
/ok-to-test |
@wendy-ha18 see linting errors per the test. |
6f2ec2a
to
2457d7a
Compare
Signed-off-by: Wendy Ha <[email protected]>
Signed-off-by: Wendy Ha <[email protected]>
2457d7a
to
0a8fb97
Compare
Signed-off-by: Wendy Ha <[email protected]>
Signed-off-by: Wendy Ha <[email protected]>
Signed-off-by: Wendy Ha <[email protected]>
Hi @jberkus I have fixed all of lint test fails and backport v3.6 to v3.5 as well. |
This PR uses to address this issue: #801 for updating the Guide to making transactional writes.
txn
and why you might want to transactionally write things (might need a maintainer to help with this!) (completed partially, need to ask for advice).