Skip to content

Add etcd-workbench link to tools #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add etcd-workbench link to tools #1027

wants to merge 4 commits into from

Conversation

tzfun
Copy link

@tzfun tzfun commented Jun 11, 2025

Add etcd-workbench link to the integrations page. Hope this helps more developers.

It is a free and powerful ui client that makes etcd management easier, with support for Windows and macOS app installations, as well as web and docker deployments.

@k8s-ci-robot
Copy link

Hi @tzfun. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jberkus
Copy link
Contributor

jberkus commented Jun 12, 2025

/ok-to-test

@tzfun
Copy link
Author

tzfun commented Jun 13, 2025

Hi @wendy-ha18 ,

Thank you for the review! I’m happy to help improve the etcd documentation. I’ve pushed a commit to address these issues—could you please take another look when you have time?

Best regards.

@wendy-ha18
Copy link

Hi @tzfun , thanks a lot for your update. Now we only need to fix some CI fails before it ready to merge:

  1. For DCO sign: according to etcd Contributing, etcd follows a rough convention for commit messages.

You can review your fail and suggestion here, you may need to Signed-off-by: Author Name <[email protected]> in your commit message based on etcd Contributing requirements.

  1. fix website-lint failed: we are failed on 3 rules:
  • MD034/no-bare-urls: we shouldn't use bare URL like [Context: "https://github.com/etcd-io"], instead of it, we should wrap them in markdown link syntax: [etcd-io repository](https://github.com/etcd-io).
  • MD036/no-emphasis-as-heading: we shouldn't use italics/bold for section headings like *Tools*, instead of it, we should use markdown headings: ## Tools.
  • MD032/blanks-around-lists: List - [edwardcapriolo/etcdcpp](https://github.com/edwardcapriolo/etcdcpp) should be surrounded by blank lines. You can review format on v3.5 and v3.6 to apply for old versions, it should have a blank line before and after the list:
### C++

- [edwardcapriolo/etcdcpp](https://github.com/edwardcapriolo/etcdcpp) - Supports v2
- ......

### Clojure

@tzfun
Copy link
Author

tzfun commented Jun 15, 2025

Hi @wendy-ha18 , I've fixed the mentioned issues. PTAL.

@wendy-ha18
Copy link

wendy-ha18 commented Jun 15, 2025

sorry @tzfun the lint tests seem still failed, just a few minor fixes left.

@tzfun
Copy link
Author

tzfun commented Jun 15, 2025

@wendy-ha18 Oh sorry! I've made the corrections. Could you please check again? (If there are still issues, could you let me know how to run the lint tests locally? That way I can catch obvious errors myself and improve my accuracy.)

@wendy-ha18
Copy link

/lgtm

@k8s-ci-robot
Copy link

@wendy-ha18: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wendy-ha18
Copy link

/approve

@wendy-ha18
Copy link

Hi @tzfun the PR is LGTM for me now, thanks for your contribution.

To be able to test the lint checks locally, you can refer to Makefile with make markdown-diff-lint command. It will ask you to install markdownlint-cli2 if you don't have, and set pull SHA commit (PULL_BASE_SHA and PULL_PULL_SHA for local test). You can view the script/markdown_diff_lint.sh for more details.

@wendy-ha18
Copy link

cc @jberkus @nate-double-u @jmhbnz, this PR is LGTM and has passed all of CI checks, could you please help me review it again and approve it if it's possible? Thanks everyone!

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tzfun, wendy-ha18
Once this PR has been reviewed and has the lgtm label, please assign serathius for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants