-
Notifications
You must be signed in to change notification settings - Fork 318
Add etcd-workbench link to tools #1027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi @tzfun. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Hi @wendy-ha18 , Thank you for the review! I’m happy to help improve the etcd documentation. I’ve pushed a commit to address these issues—could you please take another look when you have time? Best regards. |
Hi @tzfun , thanks a lot for your update. Now we only need to fix some CI fails before it ready to merge:
You can review your fail and suggestion here, you may need to
|
Signed-off-by: beifengtz <[email protected]>
Signed-off-by: beifengtz <[email protected]>
Signed-off-by: beifengtz <[email protected]>
Hi @wendy-ha18 , I've fixed the mentioned issues. PTAL. |
sorry @tzfun the lint tests seem still failed, just a few minor fixes left. |
Signed-off-by: beifengtz <[email protected]>
@wendy-ha18 Oh sorry! I've made the corrections. Could you please check again? (If there are still issues, could you let me know how to run the lint tests locally? That way I can catch obvious errors myself and improve my accuracy.) |
/lgtm |
@wendy-ha18: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/approve |
Hi @tzfun the PR is LGTM for me now, thanks for your contribution. To be able to test the lint checks locally, you can refer to Makefile with |
cc @jberkus @nate-double-u @jmhbnz, this PR is LGTM and has passed all of CI checks, could you please help me review it again and approve it if it's possible? Thanks everyone! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tzfun, wendy-ha18 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add etcd-workbench link to the integrations page. Hope this helps more developers.
It is a free and powerful ui client that makes etcd management easier, with support for Windows and macOS app installations, as well as web and docker deployments.