-
Notifications
You must be signed in to change notification settings - Fork 318
Add blog announcing-etcd-3.6.md #999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, thanks @ahrtr - putting all these together is a lot of work! Lgtm except few small inline comments.
789f632
to
4e86dc7
Compare
@ahrtr thanks so much for quickly addressing my comments! |
fa3bd24
to
8a074c2
Compare
Thanks @spzala for the quick review!!! All comments resolved and all workflows are green. Please other reviewers take a look. thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow great summary @ahrtr nice work!
A couple minor suggestions below but I think this looks great.
Let's hold for other reviewers
/hold
189cfa5
to
9098ca4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor edits, but I think we should move up a bunch of stuff, like Performance, to Features, instead of having it below Breaking Changes.
Link check completed. Ready to go. |
Thanks all for the review!!! I really appreciate it. I will merge this PR right after I release etcd v3.6.0 on May 15th (Thursday). Leave this PR to me. Thanks again!!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A copy-edit pass. Feel free to take or leave any suggestion in particular.
Through the etcd-operator Working Group, we plan to improve usability as well. | ||
|
||
What follows are the most significant changes introduced in etcd v3.6.0, along with the discussion of the | ||
roadmap for future development. For a detailed list of changes, please refer to the [CHANGELOG-3.6][]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
roadmap for future development. For a detailed list of changes, please refer to the [CHANGELOG-3.6][]. | |
roadmap for future development. For a detailed list of changes, please refer to [CHANGELOG-3.6][]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like it's better to keep the the
, it highlights a specific changelog (changelog-3.6)
_**Figure 1:** Memory usage comparison between etcd v3.5.20 and v3.6.0-rc.2 under different read/write ratios. | ||
Each subplot shows the memory usage over time with a specific read/write ratio. The red line represents etcd | ||
v3.5.20, while the teal line represents v3.6.0-rc.2. Across all tested ratios, v3.6.0-rc.2 exhibits more | ||
stable and lower memory usage._ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stable and lower memory usage._ | |
stability and lower memory usage._ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intention is to use an adjective stable
, but the original expression might be a little confusing, so just changed
from
more stable and lower memory usage
to
lower and more stable memory usage
cf727c9
to
9a3a248
Compare
38f80e0
to
c2e0fd9
Compare
Signed-off-by: Benjamin Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was finally able to read this (sorry for being late to the party). This is great. Great job leading, Benjamin, and everyone who contributed to this blog post ❤️
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, fuweid, ivanvc, jberkus, jmhbnz, serathius, spzala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jberkus thanks. Timing is good! |
We are releasing etcd v3.6.0 on May 15th, 2025 (Thursday), so we are targeting to publish the blog on the same day, right after the release of v3.6.0.
cc @fuweid @ivanvc @jberkus @jmhbnz @serathius @spzala PTAL, thx