core: simplify effectiveTip calculation #31771
Merged
+1
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
reviewed
Jun 3, 2025
fjl
changed the title
GasPrice - BaseFee instead of GasFeeCap - BaseFee
fjl
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
buyGas,GasPriceis used to conduct the gas cost.However when computing effectiveTip,
GasFeeCapis used instead.In theory,
GasFeeCap>=GasPrice, so it may happen that the tip fee is larger than it should be.This PR tries to reduce such confusion by computing
effectiveTipbyGasPrice - BaseFeeinstead ofGasFeeCap - BaseFee.Note that for all tx types,
GasFeeCap==GasPricealways holds, so there's no problem for tx. But it's still better to make it consistent .