metrics: disable CPU metrics on tinygo #31953
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omerfirmak
force-pushed
the
riscv-cpu-metrics
branch
from
f1de44c to
2a84659
Compare
omerfirmak
changed the title
fjl
reviewed
Jun 3, 2025
metrics/cpu_disabled.go
Outdated
| //go:build ios || js || wasip1 | ||
| // +build ios js wasip1 | ||
| //go:build ios || js || wasip1 || tinygo.riscv | ||
| // +build ios js wasip1 tinygo.riscv |
There was a problem hiding this comment.
I think we can just disable it on TinyGo generally. No need to make it architecture specific.
omerfirmak
changed the title
fjl
approved these changes
Jun 3, 2025
jsvisa
pushed a commit
to jsvisa/go-ethereum
that referenced
this pull request
Jun 5, 2025
Signed-off-by: jsvisa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.