core/rawdb: don't decode the full block body in ReadTransaction #32027
+159
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
changed the title
fjl
reviewed
Jun 13, 2025
core/rawdb/accessors_indexes.go
Outdated
| for txnIterator.Next() && txnIterator.Err() == nil { | ||
| txnRLP := txnIterator.Value() | ||
|
|
||
| // Figure out if this a legacy transaction or not |
There was a problem hiding this comment.
Please explain it better in the comment.
rjl493456442
previously approved these changes
Jun 18, 2025
rjl493456442
approved these changes
Jun 19, 2025
calbera
pushed a commit
to berachain/bera-geth
that referenced
this pull request
Jun 19, 2025
…reum#32027) Reading a single transaction out of a block shouldn't need decoding the entire body --------- Co-authored-by: Felix Lange <[email protected]> Co-authored-by: Gary Rong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading a single transaction out of a block shouldn't need decoding the entire body