Skip to content

eth, core: terminate the downloader immediately when shutdown signal is received #32062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 19, 2025

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Jun 18, 2025

closes #32058

Test with the hoodi testnet in full-sync, the results as below

master branch about 36seconds

INFO [06-18|15:08:01.553] Got interrupt, shutting down...
INFO [06-18|15:08:01.553] HTTP server stopped                      endpoint=[::]:4545
INFO [06-18|15:08:01.553] HTTP server stopped                      endpoint=[::]:4546
INFO [06-18|15:08:01.553] HTTP server stopped                      endpoint=[::]:8551
INFO [06-18|15:08:01.553] IPC endpoint closed                      url=/data/geth.ipc
... 
INFO [06-18|15:08:37.213] Blockchain stopped

this branch about 5seconds

INFO [06-18|15:05:20.774] Got interrupt, shutting down...
INFO [06-18|15:05:20.774] HTTP server stopped                      endpoint=[::]:4545
INFO [06-18|15:05:20.774] HTTP server stopped                      endpoint=[::]:4546
INFO [06-18|15:05:20.774] HTTP server stopped                      endpoint=[::]:8551
INFO [06-18|15:05:20.774] IPC endpoint closed                      url=/data/geth.ipc
...
INFO [06-18|15:05:25.462] Blockchain stopped

@jsvisa jsvisa requested a review from rjl493456442 as a code owner June 18, 2025 15:20
@fjl fjl self-assigned this Jun 18, 2025
@rjl493456442 rjl493456442 added this to the 1.15.12 milestone Jun 19, 2025
@rjl493456442 rjl493456442 merged commit 8219bfc into ethereum:master Jun 19, 2025
3 of 4 checks passed
@rjl493456442 rjl493456442 changed the title eth,core: terminate the downloader immediately when shutdown signal is received eth, core: terminate the downloader immediately when shutdown signal is received Jun 19, 2025
calbera pushed a commit to berachain/bera-geth that referenced this pull request Jun 19, 2025
@s1na
Copy link
Contributor

s1na commented Jun 19, 2025

Confirming this should also fix #31508??

@rjl493456442
Copy link
Member

Not sure. The hang after initial synchronization might be relevant with something else.

@jsvisa jsvisa deleted the downloader-terminate branch June 23, 2025 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terminate the downloader immediately when shutdown signal is received
4 participants