Skip to content

core/state: improve the prefetcher concurrency allowance #32071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2025

Conversation

cskiraly
Copy link
Contributor

@cskiraly cskiraly commented Jun 20, 2025

Improve the prefetcher concurrency allowance.

Moved to its own PR from #31998, which adds the statistics.

Author: @rjl493456442

@cskiraly cskiraly requested a review from rjl493456442 as a code owner June 20, 2025 18:14
@cskiraly
Copy link
Contributor Author

@rjl493456442, is this the formula we want? Isn't setLimit(0) a problem with 1 core?

@rjl493456442
Copy link
Member

// A limit of zero will prevent any new goroutines from being added.

Yes, SetLimit(0) will be one-thread mode, it's not something we want.

@rjl493456442 rjl493456442 merged commit 6eab053 into ethereum:master Jun 21, 2025
3 of 4 checks passed
@rjl493456442 rjl493456442 added this to the 1.15.12 milestone Jun 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants