Skip to content

feat: add svelte support #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 4, 2024
Merged

feat: add svelte support #198

merged 3 commits into from
Oct 4, 2024

Conversation

akadotsh
Copy link
Collaborator

No description provided.

@cezaraugusto
Copy link
Member

cc @OSpoon given your expertise adding support for Preact and Vue, could you help reviewing this one?

@OSpoon
Copy link
Member

OSpoon commented Sep 27, 2024

@akadotsh
This is a great PR. I have found that it seems there is a lack of hot updating capability. Could you please confirm this?

@akadotsh
Copy link
Collaborator Author

Thank you for the feedback, @OSpoon. I’ve reviewed the code, and you're right hot updating is not working properly. I’ll work on that and update the PR.

@OSpoon
Copy link
Member

OSpoon commented Sep 28, 2024

Thank you for the feedback, @OSpoon. I’ve reviewed the code, and you're right hot updating is not working properly. I’ll work on that and update the PR.

Here are some options related to hot updates, you can refer to them:
https://github.com/sveltejs/svelte-loader#hot-reload

@akadotsh
Copy link
Collaborator Author

Hi @OSpoon, hot update is working fine now.

Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is so cool, thanks @akadotsh for taking the time to make this happen. will be included in the next release, thanks!

@cezaraugusto cezaraugusto merged commit 44d4169 into extension-js:main Oct 4, 2024
1 check passed
Copy link

pkg-pr-new bot commented Oct 4, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/extension-js/extension.js/extension@198
pnpm add https://pkg.pr.new/extension-js/extension.js/extension-create@198
pnpm add https://pkg.pr.new/extension-js/extension.js/extension-develop@198

commit: fe48ec4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants