-
Notifications
You must be signed in to change notification settings - Fork 18
fix(tests): use chrome for unit tests instead of phantomjs #152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Perhaps its outside of the scope of this PR in particular, but there are only 3 unit tests actually being run at the moment [0], because the markdown component [1] has [0] https://ci.centos.org/job/devtools-ngx-widgets/220/console |
@jarifibrahim This commit 083bbd3 adds the same functionality i think. Its part of this Angular upgrade PR - #150 which is going to be merged soon. This PR also fixes skipping of unit tests by |
@rohitkrai03 Good find! Yeah, it looks there are existing plans to use headless chrome and re-enable the unit tests. |
I think a lot of this will be fixed by the upgrade. |
@joshuawilson so should we merge this PR? |
working on it now, should be ready today or tomorrow at the latest |
oh, sorry, this PR not the upgrade. Let me finish the upgrade and then anything left over you can submit a PR for that. The upgrade and this would be a hard rebase. |
This was taken care of in the upgrade. If you still want to remove references to PhantomJS, please submit a new PR. |
This PR