Skip to content
This repository was archived by the owner on May 7, 2021. It is now read-only.

fix(tests): use chrome for unit tests instead of phantomjs #152

Closed
wants to merge 2 commits into from
Closed

fix(tests): use chrome for unit tests instead of phantomjs #152

wants to merge 2 commits into from

Conversation

jarifibrahim
Copy link
Member

@jarifibrahim jarifibrahim commented Aug 24, 2018

This PR

  • Removes phantomjs from package.json
  • Installs chrome in the CI docker container

@jarifibrahim jarifibrahim self-assigned this Aug 24, 2018
Copy link

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rohitkrai03 rohitkrai03 changed the title fix(tests): Use chrome for unit tests instead of phantomjs fix(tests): use chrome for unit tests instead of phantomjs Aug 24, 2018
@aptmac
Copy link
Member

aptmac commented Aug 24, 2018

Perhaps its outside of the scope of this PR in particular, but there are only 3 unit tests actually being run at the moment [0], because the markdown component [1] has fit instead of it on each of it's 3 unit tests .. would you be able to change them and see how the rest of the tests perform? Unless the fit was an intentional addition of #148 ? @sanbornsen

[0] https://ci.centos.org/job/devtools-ngx-widgets/220/console
[1] https://github.com/fabric8-ui/ngx-widgets/blob/master/src/app/markdown/markdown.component.spec.ts

@rohitkrai03
Copy link

rohitkrai03 commented Aug 24, 2018

@jarifibrahim This commit 083bbd3 adds the same functionality i think. Its part of this Angular upgrade PR - #150 which is going to be merged soon. This PR also fixes skipping of unit tests by fit.
cc: @aptmac

@aptmac
Copy link
Member

aptmac commented Aug 24, 2018

@rohitkrai03 Good find! Yeah, it looks there are existing plans to use headless chrome and re-enable the unit tests.

@jarifibrahim
Copy link
Member Author

@aptmac Since the all the unit tests will be enabled in #150, should we merge this PR?

@joshuawilson
Copy link
Contributor

I think a lot of this will be fixed by the upgrade.

@jarifibrahim
Copy link
Member Author

I think a lot of this will be fixed by the upgrade.

@joshuawilson so should we merge this PR?

@joshuawilson
Copy link
Contributor

working on it now, should be ready today or tomorrow at the latest

@joshuawilson
Copy link
Contributor

oh, sorry, this PR not the upgrade. Let me finish the upgrade and then anything left over you can submit a PR for that. The upgrade and this would be a hard rebase.

@joshuawilson
Copy link
Contributor

This was taken care of in the upgrade. If you still want to remove references to PhantomJS, please submit a new PR.

@jarifibrahim jarifibrahim deleted the remove-phantomjs branch August 30, 2018 08:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants