This repository was archived by the owner on May 7, 2021. It is now read-only.
fix(markdown): emit event on outside-click if no data changed #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
@sahil143 ^^ |
|
@sahil143 can you take a look at this PR? |
|
Once this is merged, it can only be applied to the planner upgrade PR/branch as it has already been upgraded. |
|
Please update the tests. |
divyanshiGupta
force-pushed
the
issue#4049
branch
from
972f4c1 to
fc20fb8
Compare
|
@joshuawilson done |
sahil143
reviewed
Sep 27, 2018
| const clickedInside = this.elementRef.nativeElement.contains(target); | ||
|
|
||
| if (this.editorInput) { | ||
| this.isNoDataChanged = this.editorInput.nativeElement.innerText.trim() == this.rawText; |
divyanshiGupta
force-pushed
the
issue#4049
branch
from
fc20fb8 to
9296134
Compare
|
@sahil143 done |
sahil143
approved these changes
Sep 27, 2018
|
🎉 This PR is included in version 3.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: openshiftio/openshift.io#4049
This PR is a part of this PR fabric8-ui/fabric8-planner#2781 in fabric8-ui