Skip to content

Finally remove favorSafetyOverHydrationPerf #33619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

Finally remove favorSafetyOverHydrationPerf #33619

merged 1 commit into from
Jul 7, 2025
+35 −373

Conversation

rickhanlonii
Copy link
Member

This is rolled out to 100%.

Let me merge it though.

@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Jun 23, 2025
@react-sizebot
Copy link

react-sizebot commented Jun 23, 2025 •
edited
Loading

Comparing: 0378b46...a3a86eb

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.50 kB 530.50 kB = 93.66 kB 93.66 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 655.04 kB 655.04 kB = 115.35 kB 115.35 kB
facebook-www/ReactDOM-prod.classic.js = 675.12 kB 674.93 kB = 118.77 kB 118.71 kB
facebook-www/ReactDOM-prod.modern.js = 665.54 kB 665.36 kB = 117.13 kB 117.06 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against a3a86eb

@rickhanlonii rickhanlonii force-pushed the rh/rm-favorSafetyOverHydrationPerf branch from 2c49b15 to 40a93a0 Compare June 23, 2025 14:24
@kushxg kushxg mentioned this pull request Jul 1, 2025
Open
@rickhanlonii rickhanlonii force-pushed the rh/rm-favorSafetyOverHydrationPerf branch from 40a93a0 to a3a86eb Compare July 7, 2025 15:24
@rickhanlonii rickhanlonii merged commit e43986f into facebook:main Jul 7, 2025
241 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 7, 2025
@rickhanlonii
Finally remove favorSafetyOverHydrationPerf (#33619)
a357246 
This is rolled out to 100%.

Let me merge it though.

DiffTrain build for [e43986f](e43986f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rickhanlonii @react-sizebot @sebmarkbage @facebook-github-bot