Skip to content

dataconnect: create python script to post comments about scheduled runs #6880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 47 commits into from
Apr 17, 2025
Merged

dataconnect: create python script to post comments about scheduled runs #6880

merged 47 commits into from
Apr 17, 2025

Conversation

dconeybe
Copy link
Contributor

trksmnkncd_notification_issue=6863

dconeybe added 2 commits April 15, 2025 14:35
@dconeybe
dataconnect.yml: improve send-notifications message and allow specify…
a0a89a9 
…ing issue via trksmnkncd_notification_issue=6863 in the PR body
@dconeybe
ci skeleton added
38a4068
@dconeybe dconeybe self-assigned this Apr 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v10.0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 15, 2025 •
edited
Loading

Test Results

 1 064 files  +   998   1 064 suites  +998   34m 38s ⏱️ + 33m 22s
 5 874 tests + 5 322   5 851 ✅ + 5 300  22 💤 +21  1 ❌ +1 
12 117 runs  +11 013  12 072 ✅ +10 970  44 💤 +42  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 802fa36. ± Comparison against base commit 51b4a1c.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 15, 2025 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (51b4a1c) and merge commit (0c395d0).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/thpgnZFABD.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 15, 2025 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.21% (51b4a1c) to 50.16% (0c395d0) by -0.04%.

    FilenameBase (51b4a1c)Merge (0c395d0)Diff
    ChildChangeAccumulator.java96.67%83.33%-13.33%

  • firebase-firestore

    Overall coverage changed from 45.78% (51b4a1c) to 45.78% (0c395d0) by -0.00%.

    FilenameBase (51b4a1c)Merge (0c395d0)Diff
    PatchMutation.java100.00%98.39%-1.61%

  • firebase-storage

    Overall coverage changed from 84.00% (51b4a1c) to 84.33% (0c395d0) by +0.33%.

    FilenameBase (51b4a1c)Merge (0c395d0)Diff
    NetworkRequest.java87.85%87.29%-0.55%
    StorageException.java65.45%69.09%+3.64%
    StorageTask.java83.38%83.99%+0.60%
    UploadTask.java81.52%83.17%+1.65%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ksi4p3avrI.html

@dconeybe dconeybe changed the base branch from dconeybe/dataconnect/CiPostMessageImprovements to main April 17, 2025 02:02
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 17, 2025 •
edited
Loading

Startup Time Report 1

The report is too large (122,581 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/IEF3u3PhNz/index.html

dconeybe added 9 commits April 16, 2025 23:37
@dconeybe dconeybe mentioned this pull request Apr 17, 2025
Closed
@dconeybe dconeybe marked this pull request as ready for review April 17, 2025 04:43
@dconeybe dconeybe requested a review from Copilot April 17, 2025 04:44
@github-actions GitHub Actions
Copy link
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Copilot
Copilot AI reviewed Apr 17, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • firebase-dataconnect/ci/requirements.txt: Language not supported

@dconeybe dconeybe requested a review from Copilot April 17, 2025 04:46
Copilot
Copilot AI reviewed Apr 17, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • firebase-dataconnect/ci/requirements.txt: Language not supported

@dconeybe dconeybe requested a review from Copilot April 17, 2025 04:47
Copilot
Copilot AI reviewed Apr 17, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a set of Python scripts and updates to GitHub Actions workflows to enable posting comments about scheduled runs based on GitHub PR information. Key changes include:

  • A new utility module (util.py) to fetch PR details using the GitHub CLI.
  • Scripts for calculating the GitHub Issue number from PR bodies and posting job results as comments.
  • Updates to CI configuration files and workflows for testing, linting, formatting, and notifications.

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
firebase-dataconnect/ci/util.py Adds functions to fetch PR info using gh and extract PR numbers from refs.
firebase-dataconnect/ci/pyproject.toml Configures project metadata, Python version requirements, and linting rules.
firebase-dataconnect/ci/post_comment_for_job_results.py Implements logic to post comments on GitHub issues with job results.
firebase-dataconnect/ci/calculate_github_issue_for_commenting.py Adds functionality to determine the GitHub Issue for commenting from PR bodies.
firebase-dataconnect/ci/calculate_github_issue_for_commenting_test.py Provides tests covering PR ref and issue key extraction logic.
firebase-dataconnect/ci/README.md Documents the purpose and usage of CI scripts.
.github/workflows/dataconnect_demo_app.yml Updates workflow to integrate Python version configuration and notifications.
.github/workflows/dataconnect.yml Enhances workflows with new Python CI jobs and notification steps.
.github/actions/dataconnect-send-notifications/action.yml Defines a composite action for setting up notifications based on job results.
Files not reviewed (1)
  • firebase-dataconnect/ci/requirements.txt: Language not supported

@dconeybe dconeybe force-pushed the dconeybe/dataconnect/CiNotifyPython branch from d94dcd7 to 802fa36 Compare April 17, 2025 04:53
@dconeybe dconeybe requested a review from aashishpatil-g April 17, 2025 18:31
@dconeybe dconeybe merged commit bd2cb5f into main Apr 17, 2025
450 of 459 checks passed
@dconeybe dconeybe deleted the dconeybe/dataconnect/CiNotifyPython branch April 17, 2025 23:36
@firebase firebase locked and limited conversation to collaborators May 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@aashishpatil-g aashishpatil-g aashishpatil-g approved these changes

Assignees

@dconeybe dconeybe

Labels
api: dataconnect main-merge-ack no-changelog size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dconeybe @google-oss-bot @aashishpatil-g