dataconnect: use firebase-tools to launch fdc emulator instead of launching it directly #6896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Vertex AI Mock Responses Check
|
Size Report 1Affected ProductsNo changes between base commit (bd2cb5f) and merge commit (ee82191).Test Logs |
Coverage Report 1Affected Products
Test Logs |
…e version used for codegen diff --git a/.github/workflows/dataconnect.yml b/.github/workflows/dataconnect.yml index a9e895d..0e77b04 100644 --- a/.github/workflows/dataconnect.yml +++ b/.github/workflows/dataconnect.yml @@ -174,14 +174,24 @@ jobs: - name: Start Firebase Emulators run: | set -xveuo pipefail + + # Use the same dataconnect binary as was used for code generation in gradle assemble + DATACONNECT_EMULATOR_BINARY_PATH="$(find "$PWD"/firebase-dataconnect/connectors/build/intermediates/dataconnect/debug/executable -type f)" + if [[ -n $DATACONNECT_EMULATOR_BINARY_PATH ]] ; then + echo "INTERNAL ERROR v7kg2dfhbc: unable to find data connect binary" >&2 + exit 1 + fi + export DATACONNECT_EMULATOR_BINARY_PATH + export FIREBASE_DATACONNECT_POSTGRESQL_STRING='postgresql://postgres:[email protected]:5432?sslmode=disable' - export DATACONNECT_EMULATOR_BINARY_PATH="$PWD"/firebase-dataconnect/connectors/build/intermediates/dataconnect/debug/executable/dataconnect-* cd firebase-dataconnect/emulator ${{ env.FDC_FIREBASE_COMMAND }} emulators:start --only=auth,dataconnect >firebase.emulators.log 2>&1 & - name: Start Logcat Capture continue-on-error: true - run: "$ANDROID_HOME/platform-tools/adb" logcat >logcat.log 2>&1 & + run: | + set -xveuo pipefail + "$ANDROID_HOME/platform-tools/adb" logcat >logcat.log 2>&1 & - name: Gradle connectedCheck id: connectedCheck
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Firebase Tools version to v14.2.0 in the CI workflows and refactors the emulator startup process to use firebase-tools instead of directly downloading the emulator binary.
- Update Firebase Tools version in both workflow files
- Refactor emulator startup commands to locate and launch the dataconnect binary
- Rename steps (e.g. "Data Connect Emulator Start" → "Start Firebase Emulators") for better clarity
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/dataconnect_demo_app.yml | Updated FDC_FIREBASE_TOOLS_VERSION to v14.2.0 |
| .github/workflows/dataconnect.yml | Updated Firebase Tools version, removed restore-gradle-cache step, and refactored emulator start commands |
Files not reviewed (1)
- firebase-dataconnect/gradleplugin/plugin/src/main/resources/com/google/firebase/dataconnect/gradle/plugin/DataConnectExecutableVersions.json: Language not supported
dconeybe
changed the title
aashishpatil-g
approved these changes
Apr 18, 2025
dconeybe
deleted the
dconeybe/dataconnect/FirebaseToolsForDataConnectEmulator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.