Skip to content

Davidmotson.firebase ai #6911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Apr 28, 2025
Merged

Davidmotson.firebase ai #6911

merged 16 commits into from
Apr 28, 2025

Conversation

davidmotson
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v10.0

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@davidmotson davidmotson requested a review from rlazo April 25, 2025 18:57
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 25, 2025 •
edited
Loading

Size Report 1

Affected Products

  • firebase-ai

    TypeBase (12127e6)Merge (caec6e5)Diff
    aar?801 kB? (?)
    apk (aggressive)?1.54 MB? (?)
    apk (release)?9.51 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/1bNTyBtw8k.html

@davidmotson davidmotson enabled auto-merge (squash) April 25, 2025 19:04
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 25, 2025 •
edited
Loading

Test Results

 1 056 files  + 1 038   1 056 suites  +1 038   35m 23s ⏱️ + 35m 9s
 5 972 tests + 5 886   5 950 ✅ + 5 864  22 💤 +22  0 ❌ ±0 
12 007 runs  +11 835  11 963 ✅ +11 791  44 💤 +44  0 ❌ ±0 

Results for commit bffe50a. ± Comparison against base commit 12127e6.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 25, 2025 •
edited
Loading

Coverage Report 1

This report is too large (69,887 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Y4xppNijtE.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 25, 2025 •
edited
Loading

Startup Time Report 1

The report is too large (122,610 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/QMS2LK6Fbn/index.html

daymxn
daymxn reviewed Apr 25, 2025
View reviewed changes
Copy link
Member

@daymxn daymxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Left some comments, but otherwise LGTM. I defer to @rlazo for final approval tho.

davidmotson and others added 9 commits April 25, 2025 14:07
@davidmotson davidmotson merged commit 7cbb80b into main Apr 28, 2025
424 of 427 checks passed
@davidmotson davidmotson deleted the davidmotson.firebase-ai branch April 28, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daymxn daymxn daymxn left review comments

@rlazo rlazo rlazo approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidmotson @google-oss-bot @rlazo @daymxn