Skip to content

[ai] Use .json for unary tests instead of .txt #6916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Apr 29, 2025
Merged

[ai] Use .json for unary tests instead of .txt #6916

merged 20 commits into from
Apr 29, 2025

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Apr 28, 2025

Follow up to #6915

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v10.1

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 28, 2025

Copy link
Contributor

github-actions bot commented Apr 28, 2025

Test Results

 22 files   -  1 034   22 suites   - 1 034   14s ⏱️ - 36m 12s
 98 tests  -  5 874   98 ✅  -  5 852  0 💤  - 22  0 ❌ ±0 
196 runs   - 11 811  196 ✅  - 11 767  0 💤  - 44  0 ❌ ±0 

Results for commit e969f46. ± Comparison against base commit 7cbb80b.

This pull request removes 5874 tests.
com.google.android.datatransport.cct.CctBackendFactoryTest ‑ create_returnCCTBackend_WhenBackendNameIsCCT
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldOnlySupportProtoAndJson
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldSupportProtoAndJson
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOffline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOnline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldAddCookieOnPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldDropCookieOnMixedPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_CompressedResponseIsUncompressed
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirectsMoreThan5Times_shouldOnlyRedirect4Times
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirects_shouldCorrectlyFollowTheRedirectViaPost
…

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 28, 2025

Base automatically changed from davidmotson.firebase-ai to main April 28, 2025 20:13
Copy link
Contributor

github-actions bot commented Apr 29, 2025

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@rlazo rlazo requested review from davidmotson and daymxn April 29, 2025 03:50
@rlazo rlazo enabled auto-merge (squash) April 29, 2025 03:52
@rlazo rlazo merged commit 7924813 into main Apr 29, 2025
31 checks passed
@rlazo rlazo deleted the rl.txt.to.json.ai branch April 29, 2025 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants