-
Notifications
You must be signed in to change notification settings - Fork 612
Fix AI test timeout #6917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AI test timeout #6917
Conversation
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Vertex AI Mock Responses Check
|
Size Report 1Affected ProductsNo changes between base commit (cbd9636) and merge commit (acad1d9).Test Logs |
Coverage Report 1Affected ProductsNo changes between base commit (cbd9636) and merge commit (acad1d9).Test Logs |
Its worth appying this same fix to firebase-vertex as well |
Thanks for the fix Daymon. I think the state of the PR got corrupted somehow and now it wants to do a lot of changes. Could you rebase, or re-create the PR, to isolate the fix? |
96540e6
to
83a513a
Compare
They use the same function, so it's already applied to both.
Fixed:) |
David meant the file in |
Ahh I see. Done. |
Per b/414406390,
This fixes the issue with long text golden files timing out the tests. This occurred because the text contents were too large for the channel's buffer- so the channel entered a suspension point until the content was read. Unfortunately, this suspension point blocked the test thread. To solve this, we do the same thing we do for
goldenStreamingFile
- we write to the channel in a separate coroutine scope. This allows Kotlin to properly recognize that the suspension point within the writer should allow for the test thread to continue.