Skip to content

Fix AI test timeout #6917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2025
Merged

Fix AI test timeout #6917

merged 3 commits into from
Apr 30, 2025

Conversation

daymxn
Copy link
Member

@daymxn daymxn commented Apr 28, 2025

Per b/414406390,

This fixes the issue with long text golden files timing out the tests. This occurred because the text contents were too large for the channel's buffer- so the channel entered a suspension point until the content was read. Unfortunately, this suspension point blocked the test thread. To solve this, we do the same thing we do for goldenStreamingFile- we write to the channel in a separate coroutine scope. This allows Kotlin to properly recognize that the suspension point within the writer should allow for the test thread to continue.

Copy link
Contributor

github-actions bot commented Apr 28, 2025

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v11.0

@daymxn daymxn changed the base branch from main to davidmotson.firebase-ai April 28, 2025 18:50
@daymxn daymxn removed the size/XXL label Apr 28, 2025
Copy link
Contributor

github-actions bot commented Apr 28, 2025

Test Results

 40 files  + 18   40 suites  +18   29s ⏱️ +15s
184 tests + 86  184 ✅ + 86  0 💤 ±0  0 ❌ ±0 
368 runs  +172  368 ✅ +172  0 💤 ±0  0 ❌ ±0 

Results for commit 0e4bffc. ± Comparison against base commit cbd9636.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 28, 2025

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

The report is too large (122,604 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/92HLJy0Vck/index.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 28, 2025

@davidmotson
Copy link
Collaborator

Its worth appying this same fix to firebase-vertex as well

Base automatically changed from davidmotson.firebase-ai to main April 28, 2025 20:13
@rlazo
Copy link
Collaborator

rlazo commented Apr 29, 2025

Thanks for the fix Daymon. I think the state of the PR got corrupted somehow and now it wants to do a lot of changes. Could you rebase, or re-create the PR, to isolate the fix?

@daymxn daymxn changed the base branch from main to davidmotson.google_ai April 29, 2025 03:53
@daymxn daymxn changed the base branch from davidmotson.google_ai to main April 29, 2025 03:55
@daymxn
Copy link
Member Author

daymxn commented Apr 29, 2025

Its worth appying this same fix to firebase-vertex as well

They use the same function, so it's already applied to both.

Thanks for the fix Daymon. I think the state of the PR got corrupted somehow and now it wants to do a lot of changes. Could you rebase, or re-create the PR, to isolate the fix?

Fixed:)

@daymxn daymxn enabled auto-merge (squash) April 29, 2025 16:11
@rlazo
Copy link
Collaborator

rlazo commented Apr 30, 2025

Its worth appying this same fix to firebase-vertex as well

They use the same function, so it's already applied to both.

Thanks for the fix Daymon. I think the state of the PR got corrupted somehow and now it wants to do a lot of changes. Could you rebase, or re-create the PR, to isolate the fix?

Fixed:)

David meant the file in firebase-vertexai/ too, as your change fixes the one in firebase-ai/

@daymxn
Copy link
Member Author

daymxn commented Apr 30, 2025

Its worth appying this same fix to firebase-vertex as well

They use the same function, so it's already applied to both.

Thanks for the fix Daymon. I think the state of the PR got corrupted somehow and now it wants to do a lot of changes. Could you rebase, or re-create the PR, to isolate the fix?

Fixed:)

David meant the file in firebase-vertexai/ too, as your change fixes the one in firebase-ai/

Ahh I see. Done.

@daymxn daymxn merged commit 7b7e11e into main Apr 30, 2025
36 checks passed
@daymxn daymxn deleted the daymon-fix-tests branch April 30, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants