[Ai] Add workaround for invalid SafetyRating from the backend. #6925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a bug in the backend, it's possible that we receive an invalid `SafetyRating` value, without either category or probability. We return null in those cases to enable filtering by the higher level types.
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Vertex AI Mock Responses Check
|
Generated by 🚫 Danger |
daymxn
approved these changes
May 1, 2025
Coverage Report 1Affected ProductsNo changes between base commit (4b12b33) and merge commit (090723f).Test Logs |
Test Results 22 files - 18 22 suites - 18 35s ⏱️ +7s Results for commit 70cc020. ± Comparison against base commit 4b12b33. This pull request removes 86 and adds 2 tests. Note that renamed tests count towards both. |
andrewheard
reviewed
May 1, 2025
Size Report 1Affected Products
Test Logs |
daymxn
added a commit
that referenced
this pull request
May 7, 2025
Per [b/414829218](https://b.corp.google.com/issues/414829218), This ensures the Vertex AI SDK is properly aligned for the upcoming release. More specifically, this PR does the following: - Adds deprecation notices for all the public classes and interfaces, **besides** the root `FirebaseVertexAI` class and the relevant extension methods. - Updates the golden file version. - Adds the change from #6925 for working around invalid `SafetyRating`(s). - Adds a changelog entry that aligns with the deprecation notices. - Adds the changes from #6939 for tracking bidi usage. - Adds the changes from #6910 for aligning the bidi protos. --------- Co-authored-by: Rodrigo Lazo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug in the backend, it's possible that we receive an invalid
SafetyRatingvalue, without either category or probability. We return null in those cases to enable filtering by the higher level types.