[Ai] Fix test code to point to the right resource dir #6932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The devAPI helper method should read from the `googleai/` directory instead of the `vertexai/` one.
Tests were failing because they were looking at the finish reason in every data chunck instead of the last one.
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Vertex AI Mock Responses Check
|
Generated by 🚫 Danger |
Coverage Report 1Affected ProductsNo changes between base commit (24dd7c4) and merge commit (3459961).Test Logs |
Size Report 1Affected Products
Test Logs |
rlazo
requested review from
davidmotson and
daymxn
and removed request for
davidmotson
|
FirebaseExtended/vertexai-sdk-test-data#38 Introduces the fix necessary to get the tests running |
emilypgoogle
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The devAPI helper method should read from the
googleai/directory instead of thevertexai/one.Additionally, fixed tests broken by the change.