Skip to content

Update headers to track vertex ai/developer usage in kotlin #6944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2025

Conversation

VinayGuthal
Copy link
Contributor

This change is required to track the usage of vertex ai/developer api in kotlin. This change adds a suffix to the version value in the headers we send to the backend (This will mainly distinguish between the 16.0.0 versions from the old sdk and the new one)

Copy link
Contributor

github-actions bot commented May 8, 2025

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@VinayGuthal VinayGuthal requested a review from rlazo May 8, 2025 17:26
@rlazo rlazo requested a review from daymxn May 8, 2025 17:27
@google-oss-bot
Copy link
Contributor

Copy link
Contributor

github-actions bot commented May 8, 2025

Test Results

 18 files  ±0   18 suites  ±0   34s ⏱️ ±0s
 88 tests ±0   88 ✅ ±0  0 💤 ±0  0 ❌ ±0 
176 runs  ±0  176 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 30951e7. ± Comparison against base commit 7b1855d.

@VinayGuthal VinayGuthal merged commit f4649cd into main May 8, 2025
33 checks passed
@VinayGuthal VinayGuthal deleted the update_header branch May 8, 2025 17:35
@google-oss-bot
Copy link
Contributor

daymxn pushed a commit that referenced this pull request May 8, 2025
This change is required to track the usage of vertex ai/developer api in
kotlin. This change adds a suffix to the version value in the headers we
send to the backend (This will mainly distinguish between the 16.0.0
versions from the old sdk and the new one)
daymxn added a commit that referenced this pull request May 8, 2025
daymxn added a commit that referenced this pull request May 9, 2025
#6949)

This reverts commit #6944.

The change was meant to be for `firebase-ai`, which we corrected with
#6948.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants