Skip to content

Group public headers into Public directories #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2017
Merged

Group public headers into Public directories #112

merged 2 commits into from
Jun 29, 2017

Conversation

paulb777
Copy link
Member

Make public header organization in podspec's more robust and manageable. Issue #23.

Copy link
Contributor

@XiangtianDai XiangtianDai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you plan to have a follow-up to get rid of the "Private/" subdirectory?

@paulb777
Copy link
Member Author

@XiangtianDai I could follow up and contents of the Private subdirectory to their previous locations. Do you want that?

@XiangtianDai
Copy link
Contributor

@paulb777 What I wish is to get rid of the apparent inconsistency between top-level files under Source/ and files under subdirectories. Right now (in your branch) all top-level .h files are in either Public/ or Private/ while .m files sit directly in Source/, however in a subdirectory, say, Source/RPCs, .m files are private .h files are mixed together. Not a big deal, but it would be nice to have a cleaner way to structure them.

@paulb777
Copy link
Member Author

@XiangtianDai The only requirement from a unit testing perspective is that public headers are in separate directories from private headers, so that module headers don't collide with the source versions. I'll do a follow up PR to restore the headers from Private and leave any additional reorganization to you.

@paulb777 paulb777 merged commit c33bdff into master Jun 29, 2017
@paulb777 paulb777 deleted the core-public branch June 29, 2017 19:03
XiangtianDai pushed a commit that referenced this pull request Jul 28, 2017
Add auth language chooser to facilitate manual testing.
minafarid pushed a commit to minafarid/firebase-ios-sdk that referenced this pull request Jun 6, 2018
@firebase firebase locked and limited conversation to collaborators Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants