Add tests for ppl 1 #14885
Open
Add tests for ppl 1 #14885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherylEnkidu
added
api: messaging
api: storage
api: dynamiclinks
api: performance
api: remoteconfig
api: functions
api: inappmessaging
cherylEnkidu
added
api: firestore
and removed
api: messaging
api: storage
api: firestore
api: dynamiclinks
api: performance
api: remoteconfig
api: functions
api: inappmessaging
cherylEnkidu
commented
May 27, 2025
| self = [super init]; | ||
| if (self) { | ||
| collection_source = std::make_shared<CollectionSource>(MakeString(path)); | ||
| if (ref.firestore.databaseID.CompareTo(db.databaseID) != ComparisonResult::Same) { | ||
| ThrowInvalidArgument( |
There was a problem hiding this comment.
I am leaning towards propagating this error to the Swift layer and making it a fatal error to avoid introducing more throw statement in objective-c layer.
The reason for not making it throwable is I would like not to make the db.pipeline().collection("") a throwable function.
For more info: go/firestore-ios-sdk-errors
There was a problem hiding this comment.
Note: There would be some effort to test the fatal error in Swift, since there is no build in functions in Swift library for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#no-changelog