Clean up logging and configuration in Messaging #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cleans up some left-over old logging logic from before we moved to FIRLogger in Firebase Core. We no longer need this logging functionality.
We no longer need a config class to store an unused log level filter (that filter is no longer needed).
paulb777
approved these changes
May 25, 2017
paulb777
pushed a commit
that referenced
this pull request
May 25, 2017
NS_SWIFT_NAME will only work for factory methods in Xcode 7.0-7.2. This will remove the Macro to retain support for Objective-C users. See b/37716091 for more details.
paulb777
added a commit
that referenced
this pull request
May 25, 2017
* Initial commit * Initial * Add three files in repo despite .gitignore * Update README with context, contributing, and license sections (#3) * Updating READMEs (#5) * Add comments to each FIRLoggerLevel value. (#6) Docs aren't being generated properly for FIRLoggerLevel because it's missing the proper documentation. * Update travis for renamed AllUnitTests scheme (#8) * Remove double commented lines. (#11) * Update scheme setting in test.sh (#12) * Update travis xcode version to 8.3 (#13) * Add CI badge to README (#14) * Fix typos (#15) * Adding cache to Travis builds (#17) * Enable direct channel in the sample app (#7) This shows the simple property, shouldEstablishDirectChannel, to open a new channel, and how to show incoming messages with the iOS 10 delegate handler * Auth jazzy fixes and Swift sample updates (#19) * Removes the '@c' that would cause Jazzy issue down the road. * Update travis test to retry if error is 65 (#20) * Fixes ApiTests and separates its credentials from Sample (#25) * Log an error if for some reason we can't add a method to a class (#24) Maybe it was already swizzled, or some other issue. Either way, it would be good to log this error, as it might help us / developers diagnose an issue. * Update FIRPhoneAuthProvider reference docs (#27) Adds reference docs error documentation to FIRPhoneAuthProvider. Also fixes small typo in FIRAuthErrorUtils. * Clean up logging and configuration in Messaging (#28) * Remove mostly unused code from FIRMessagingLogger This cleans up some left-over old logging logic from before we moved to FIRLogger in Firebase Core. We no longer need this logging functionality. * Delete FIRMessagingConfig.{h,m} We no longer need a config class to store an unused log level filter (that filter is no longer needed).
minafarid
pushed a commit
to minafarid/firebase-ios-sdk
that referenced
this pull request
Jun 6, 2018
* Remove mostly unused code from FIRMessagingLogger
This cleans up some left-over old logging logic from before we moved to FIRLogger in Firebase Core. We no longer need this logging functionality.
* Delete FIRMessagingConfig.{h,m}
We no longer need a config class to store an unused log level filter (that filter is no longer needed).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up some left-over old logging logic from before we moved to FIRLogger in Firebase Core. We no longer need this logging functionality. As a result, we can also remove FIRMessagingConfig, as its only job was to store a default log level filter (something we don't need anymore, as FIRLogger has its own filter).