Skip to content

Uses official Firebase Auth product names in code and doc. #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2017

Conversation

XiangtianDai
Copy link
Contributor

Also fixes minor leftovers from previous auth credential refactory.

Please note the strings for the Firebase Auth sample was not needed in the first place, because Firebase Auth has no user visible strings so far. It was a leftover when Firebase Auth and Firebase Auth UI were developed in the same repository.

Also fixes minor leftovers from previous auth crendetial refactory.
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for RTDB

@XiangtianDai XiangtianDai merged commit 7ac4caa into master May 27, 2017
@XiangtianDai XiangtianDai deleted the auth-bear-spray branch May 27, 2017 00:08
minafarid pushed a commit to minafarid/firebase-ios-sdk that referenced this pull request Jun 6, 2018
Also fixes minor leftovers from previous auth crendetial refactory.
@firebase firebase locked and limited conversation to collaborators Nov 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants