Skip to content

Adds GoogleService-Info_multi.plist to the Auth Sample #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 26, 2017

Conversation

XiangtianDai
Copy link
Contributor

so the Auth Sample app no longer crashes on the settings view.

Copy link
Contributor

@protocol86 protocol86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@XiangtianDai XiangtianDai merged commit af8b54f into master May 26, 2017
@XiangtianDai XiangtianDai deleted the auth-sample-settings-crash-fix branch May 26, 2017 01:20
minafarid pushed a commit to minafarid/firebase-ios-sdk that referenced this pull request Jun 6, 2018
* Adds GoogleService-Info_multi.plist to the Auth Sample so it no longer crashes on the settings view.
* Also relaxes requirement of time differences in unit tests because Travis is slower.

* Relaxes requirement of time difference because unit tests executes slower on Travis.

* Applies the same relaxation on all time comparisons.
@firebase firebase locked and limited conversation to collaborators Nov 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants