Update error messages to be Swift friendly. #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error messages should include Swift references on top of the Objective-C references.
XiangtianDai
approved these changes
May 30, 2017
Firebase/Auth/Source/FIRAuth.m
Outdated
| @"`[FIRApp configure];` is called in " | ||
| @"`application:didFinishLaunchingWithOptions:`."]; | ||
| @"`[FIRApp configure];` (`FirebaseApp.configure()` in Swift) in the App " | ||
| @"Delegate's `application:didFinishLaunchingWithOptions:`."]; |
There was a problem hiding this comment.
Do we need to refer to the Swift method name for the app delegate method as well here as well?
There was a problem hiding this comment.
Good idea! I'll add it.
XiangtianDai
approved these changes
May 30, 2017
minafarid
pushed a commit
to minafarid/firebase-ios-sdk
that referenced
this pull request
Jun 6, 2018
* Update error messages to be Swift friendly. Error messages should include Swift references on top of the Objective-C references. * Add semicolon to [FIRApp configure] for consistency. * Add Swift reference for application(_:didFinishLaunchingWithOptions:)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error messages should include Swift references on top of the
Objective-C references.
Fixes issue #39