Skip to content

add test 606 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

add test 606 #7

wants to merge 2 commits into from

Conversation

xdongyan
Copy link
Contributor

@xdongyan xdongyan commented Aug 9, 2017

No description provided.

Copy link
Owner

@fishercoder1534 fishercoder1534 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open separate PR for these two commits.

@@ -38,4 +38,12 @@ public void test2(){
System.out.println("Test2");
assertEquals("1(2()(4))(3)", test.tree2str(t));
}
@Test
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave a blank line between tests please.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, each time when I PR for a file and I need to close it for the second file that I want to PR?

@@ -38,4 +38,12 @@ public void test2(){
System.out.println("Test2");
assertEquals("1(2()(4))(3)", test.tree2str(t));
}
@Test
public void test3(){
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a space between () and {, or you could always select all and format all before you submit a PR.

@@ -52,10 +52,27 @@ private int compute(int[] b) {
a[a.length-1] = first;
return a;
}
//**credit : https://discuss.leetcode.com/topic/58459/java-o-n-solution-with-explanation
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave a blank line in between different functions.

@xdongyan xdongyan closed this Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants