Skip to content

Add Linkding support #1942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

atomdmac
Copy link

@atomdmac atomdmac commented May 5, 2025

Adding support for syncing with https://linkding.link

@marcelklehr
Copy link
Member

Hello Adam!

Wow! Thank you for your work on this! Overall the code looks really good, great job!

Here are a few pointers:

  1. While the Bookmarks class has a tags property, the sync algorithm currently does not support tags, because no browser (to my knowledge) currently exposes tags in the web extensions API, so floccus is not able to sync tags right now.
  2. The TEST_LINKDING_SERVER action also needs to be implemented in the native actions.js file

The lack of folder support on linkding's side is a bit of a poblem, as the test suite currently assumes all adapters are capable of dealing with folders. Given that linkding doesn't support folders and floccus doesn't support tags, I'm not sure if we should go through with integrating linkding at all. I'll try to make up my mind in the next couple of days.

Still, thank you for your work on this!

@thinkingofmaud
Copy link

thinkingofmaud commented May 8, 2025

Given that linkding doesn't support folders and floccus doesn't support tags, I'm not sure if we should go through with integrating linkding at all. I'll try to make up my mind in the next couple of days.

Suggestion:

Add or update a single tag with floccus folder path and a floccus prefix as 'floccus:folder/subfolder/subfolderofsubfolder'. When pulling, put everything that does not have the 'floccus:' prefix on root.
Ignore all other tags.

Add a disclaimer to the ui when adding:

  • linkding support is experimental
  • it will break linkding tags

(i'm currently trying to get away from linkwarden because it is too bulky, looking at this as an alternative right now)

@marcelklehr
Copy link
Member

Thank you for your patience, everyone. I decided to not accept this PR right now, as I think linkding's data model is too different from the browser in its current state. I've tried something similar to what @thinkingofmaud suggested before and it didn't work very well. I'm sorry for the inevitable disappointment this decision causes.

Wishing everyone a good rest of the day 👋

@atomdmac
Copy link
Author

@marcelklehr No worries :) These changes are working quite well for my personal use at the moment but I can understand why they wouldn't necessarily fit into this project. I'm happy to continue maintaining my own fork for now.

Thanks for taking a look and for your hard work on building this project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants