Reintroduce default state machine for Provider controller #1112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matheus Pimenta <[email protected]>
matheuscscp
commented
May 6, 2025
Comment on lines
-85
to
-92
| // Suspend the provider to prevent finalizer from getting removed. | ||
| // Ensure only flux finalizer is set to allow the object to be garbage | ||
| // collected at the end. | ||
| // NOTE: Suspending and updating finalizers are done separately here as | ||
| // doing them in a single patch results in flaky test where the finalizer | ||
| // update doesn't gets registered with the kube-apiserver, resulting in | ||
| // timeout waiting for finalizer to appear on the object below. | ||
| provider.Spec.Suspend = true |
There was a problem hiding this comment.
If in the previous version .suspend blocks removing the finalizer, in this PR it should block adding the finalizer. But we don't do this anywhere else, so I think .suspend is not needed for anything in this controller. (It's needed only in the event handler)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After introducing the token cache the Provider controller now has a reason to keep a finalizer at all times. It must use it to block the object deletion from etcd until it has a chance to observe it and cleanup the token cache. So instead of being a controller that tries to remove the finalizer all the time, it's now again a controller that tries to add the finalizer all the time until deletion is observed.