MODLD-630: Do not set RESOURCE_PREFERRED flag when resource is created from Bib #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the RESOURCE_PREFERRED flag when creating a resource from a Bib record. The changes update both the integration tests and the main mapper to no longer expect or set the RESOURCE_PREFERRED property.
- Removed the RESOURCE_PREFERRED flag from the expected mappings in the tests.
- Removed the setting of RESOURCE_PREFERRED in the ConceptFormMapper’s creation of resources.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/test/java/org/folio/marc4ld/mapper/field008/Marc2LdConceptFormIT.java | Removed RESOURCE_PREFERRED flag from expected test maps |
| src/main/java/org/folio/marc4ld/service/marc2ld/bib/mapper/custom/ConceptFormMapper.java | Removed setting of RESOURCE_PREFERRED on created resource |
pkjacob
commented
May 29, 2025
| @@ -94,8 +93,7 @@ protected void addSubResource(Resource resource, char code) { | |||
| LABEL.getValue(), List.of(CODE_TO_LCCN_MAP.get(code)) | |||
| ), Collections.emptyMap()); | |||
| var form = createResource(Set.of(FORM), Map.of( | |||
| NAME.getValue(), List.of(CODE_TO_LABEL_MAP.get(code)), | |||
| RESOURCE_PREFERRED.getValue(), List.of("true") | |||
There was a problem hiding this comment.
As this resource is created from MARC Bib record, do not set the RESOURCE_PREFERRED flag.
|
zepheiryan
approved these changes
May 29, 2025
PBobylev
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the decision we made during the beginning of this project,
"http://library.link/vocab/resourcePreferred": trueproperty should be added to a resource node only when that resource is created out of a MARC authority record.In this case, this property was added to a node created out of Bib MARC records. This PR fixes the problem.