Skip to content

OKAPI-1208: refreshtoken client sets X-Okapi-Tenant #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

adamdickmeiss
Copy link
Contributor

@adamdickmeiss adamdickmeiss commented May 5, 2025

https://folio-org.atlassian.net/browse/OKAPI-1208

although this information is already part of value in X-Okapi-Token.

This is required as folio module sidecar requires X-Okapi-Tenant to be set.

although this information is already part of value in X-Okapi-Token.
This is required as folio module sidecar requires X-Okapi-Tenant
to be set.
@jakub-id
Copy link
Contributor

jakub-id commented May 6, 2025

What takes precedence in Okapi?

@adamdickmeiss
Copy link
Contributor Author

What takes precedence in Okapi?

X-Okapi-Tenant. In reality they must both match as mod-authtoken checks that they are the same.

@julianladisch julianladisch self-requested a review May 7, 2025 11:39
Copy link

sonarqubecloud bot commented May 7, 2025

Copy link
Contributor

@julianladisch julianladisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@adamdickmeiss adamdickmeiss merged commit 77f5ba5 into master May 8, 2025
5 checks passed
@adamdickmeiss adamdickmeiss deleted the OKAPI-1208-refresh-token-client-set-x-okapi-tenant branch May 8, 2025 09:23
@julianladisch julianladisch changed the title refreshtoken client sets X-Okapi-Tenant OKAPI-1208: refreshtoken client sets X-Okapi-Tenant May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants