Skip to content

build: change stripes-erm-components dep for snapshot to >= #3393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025

Conversation

EthanFreestone
Copy link

This was missed in the Sunflower changes, stripes-erm-components was moved to v10.0.x.

This is a bit of a grey area to me as to who is responsible for keeping this up to date. The last bump was performed by @zburke and the one before that was me.

I see that stripes-authority-components, stripes-inventory-components, and stripes-marc-components are set up to use >= for snapshot, and so I'd like to mirror that here and avoid the dance needing to happen every time a major bump occurs.

Of course the expectation is that major releases will be announced in the #folio-releases channel and end up in the bugfest/release environments as before

This was missed in the Sunflower changes, stripes-erm-components was moved to v10.0.x.

This is a bit of a grey area to me as to who is responsible for keeping this up to date. The last bump was performed by @zburke and the one before that was me.

 I see that `stripes-authority-components`, `stripes-inventory-components`, and `stripes-marc-components` are set up to use `>=` for snapshot, and so I'd like to mirror that here and avoid the dance needing to happen every time a major bump occurs.

Of course the expectation is that major releases will be announced in the `#folio-releases` channel and end up in the bugfest/release environments as before
@EthanFreestone EthanFreestone requested a review from zburke May 16, 2025 10:36
@EthanFreestone
Copy link
Author

Apologies if you're not the right person to merge this @zburke :) Happy to bring this to whoever's attention I need to

@zburke zburke merged commit 7acc5e5 into snapshot May 16, 2025
3 checks passed
@zburke
Copy link
Member

zburke commented May 16, 2025

@EthanFreestone, for the #snapshot branch, I agree that all @folio/... deps should use >= dependencies in order to make sure it is built with bleeding-edge builds.

@zburke zburke deleted the EthanFreestone-patch-1 branch May 16, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants