Skip to content

[family_and_style_max_length] Modernize check #5020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

[family_and_style_max_length] Modernize check #5020

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
137e9ac
Change static font check to check NameID 1, rather than 4
arrowtype May 7, 2025
e76068e
Update variable test to check length of family name plus STAT names
arrowtype May 8, 2025
75926ec
Improve specificity of FAIL messages
arrowtype May 8, 2025
e6dc9a8
Correct problems in STAT check; add back fvar check if STAT missing
arrowtype May 8, 2025
e5b1a4b
improve output formatting for static check
arrowtype May 8, 2025
38fcd0d
Run Black formatter
arrowtype May 8, 2025
20f2977
Note uncertainty about NameID 21
arrowtype May 8, 2025
2b2d9d5
Update changelog
arrowtype May 8, 2025
a27ad8a
formatting for lint test
arrowtype May 8, 2025
9f951d4
add detail on length limit
arrowtype May 8, 2025
0280c01
Formatting for linter
arrowtype May 8, 2025
275aab9
Test update: use static font, check nameID 1 rather than 4
arrowtype May 13, 2025
ff5b777
adjust fvar check to test for >31 characters
arrowtype May 13, 2025
3f95f11
add test for long STAT table entry
arrowtype May 13, 2025
20e7d1f
formatting
arrowtype May 13, 2025
e9549ed
formatting
arrowtype May 13, 2025
a15141d
fix index error, break out of loop after first run
arrowtype May 13, 2025
26d95f0
fix failing test
arrowtype May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Change static font check to check NameID 1, rather than 4
  • Loading branch information
@arrowtype
arrowtype committed May 7, 2025
commit 137e9acef833f446b45c7ea3b95aaa3a5b6dd112
2 changes: 1 addition & 1 deletion Lib/fontbakery/checks/name/family_and_style_max_length.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def strip_ribbi(x):
checks = [
[
FAIL,
NameID.FULL_FONT_NAME,
NameID.FONT_FAMILY_NAME,
32,
(
"with the dropdown menu in old versions of Microsoft Word"
Expand Down
Loading