Skip to content

easy installer #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

easy installer #20

wants to merge 2 commits into from

Conversation

MISTERNEGATIVE21
Copy link
Contributor

plz check this installer

plz check this installer
Copy link
Contributor Author

@MISTERNEGATIVE21 MISTERNEGATIVE21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

Copy link
Contributor Author

@MISTERNEGATIVE21 MISTERNEGATIVE21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final check

Copy link
Member

@anuran-roy anuran-roy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issues to take care of:

  1. Send the pull request to the dev branch and NOT the main branch.

  2. Can you just change python-dev to python3-dev in lines 65 to 67? I think that Python 2.7 is being installed and Python3 is being removed from the default python alias for some distros.

Great work on the other parts! 😄

Example screenshot:

image

@MISTERNEGATIVE21
Copy link
Contributor Author

Ok understood

@MISTERNEGATIVE21 MISTERNEGATIVE21 deleted the MISTERNEGATIVE21-patch-1 branch July 24, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants