fix: Remove unnecessary non-PID 1 log output #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed an `eprintln!` statement that logged when the process was not running as PID 1. Observing the recent health-check logs, I find this redundant, un-necessary and in some cases confusing. The whole purpose of these logs is to ensure that the Devops engineer is able to confirm that the application is being run as PID 1 and something else is not configured as entry point in the docker container. We already provide logs when it is currently run as PID 1. Right now, when we relaunch the process - it's is launched as a child process and they log these extra message (pid1-rs: Process not running as Pid 1) which makes all the logs confusing since we see series of this message.
snoyberg
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed an
eprintln!statement that logged when the process was not running as PID 1. Observing the recent health-check logs, I find this redundant, un-necessary and in some cases confusing.The whole purpose of these logs is to ensure that the Devops engineer is able to confirm that the application is being run as PID 1 and something else is not configured as entry point in the docker container. We already provide logs when it is currently run as PID 1. Right now, when
pid1library relaunch the process - it's is launched as a child process and they log these extra message (eg: pid1-rs: Process not running as Pid 1) which makes it confusing since we see series of logs saying it is running as pid 1 and then sdaying it's not running as pid 1. This PR should hopefully improve the current state.