-
Notifications
You must be signed in to change notification settings - Fork 8.4k
feat: Unit Price Items (backport #46214) #47410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
marination
merged 15 commits into
version-15-hotfix
from
mergify/bp/version-15-hotfix/pr-46214
May 23, 2025
Merged
feat: Unit Price Items (backport #46214) #47410
marination
merged 15 commits into
version-15-hotfix
from
mergify/bp/version-15-hotfix/pr-46214
May 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit c1e4e7a) # Conflicts: # erpnext/controllers/accounts_controller.py # erpnext/selling/doctype/quotation/quotation.json # erpnext/selling/doctype/sales_order/sales_order.py # erpnext/selling/doctype/selling_settings/selling_settings.json
(cherry picked from commit 71f65ba) # Conflicts: # erpnext/selling/doctype/sales_order/sales_order.py
- chore: Extract `set_unit_price_items_note` into a util (cherry picked from commit e403d3f) # Conflicts: # erpnext/buying/doctype/buying_settings/buying_settings.json # erpnext/buying/doctype/purchase_order/purchase_order.json # erpnext/buying/doctype/request_for_quotation/request_for_quotation.json # erpnext/selling/doctype/quotation/quotation.json # erpnext/selling/doctype/selling_settings/selling_settings.json
(cherry picked from commit 8f96c0b) # Conflicts: # erpnext/buying/doctype/request_for_quotation/test_request_for_quotation.py # erpnext/buying/doctype/supplier_quotation/test_supplier_quotation.py
- chore: Fix error message in accounts controller (cherry picked from commit eea758f) # Conflicts: # erpnext/buying/doctype/purchase_order/test_purchase_order.py # erpnext/buying/doctype/supplier_quotation/test_supplier_quotation.py
(cherry picked from commit 55981c8) # Conflicts: # erpnext/selling/doctype/sales_order/test_sales_order.py
- The unit price check should depend on the row qty being 0 - Once the row ceases to be 0, it is treated as an ordinary row - test: PO, SO and Quotation (cherry picked from commit 0447c7b) # Conflicts: # erpnext/selling/doctype/quotation/test_quotation.py # erpnext/selling/doctype/sales_order/test_sales_order.py
- `refresh` gets triggered twice and that renders the note twice - Remove any existing note before rendering (cherry picked from commit bf62f9a)
This comment was marked as outdated.
This comment was marked as outdated.
- The portal uses `create_supplier_quotation` for SQ creation which excludes 0 qty items
Linter failure is unrelated to the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #47537
Docs:
Closes #36012 (Refer for more Info)
Concept
Examples:
Setup and Working
has_unit_price_items
if allowed via Settings and if it has any 0 qty itemsUpdating the SO/PO
Users can decide to manage their Transactions in two ways
TODO: