fix: setting paid amount to 0 when is_paid is unchecked in purchase invoice #47679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
accounts
needs-tests
ruthra-kumar
approved these changes
May 27, 2025
ruthra-kumar
force-pushed
the
fix-pur-piad
branch
from
aacd9bf to
e358a9e
Compare
ruthra-kumar
approved these changes
May 27, 2025
ruthra-kumar
added a commit
that referenced
this pull request
May 27, 2025
…-47679 fix: setting paid amount to 0 when is_paid is unchecked in purchase invoice (backport #47679)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the is_paid checkbox is initially marked as 1 and a value is entered in the paid_amount field, and then is_paid is later unchecked (set to 0), the system still considers the value in paid_amount when calculating the outstanding amount.
This appears to be inconsistent, as unchecking is_paid should ideally reset or ignore the paid_amount value in the outstanding calculation.
Frappe Support Issue: https://support.frappe.io/app/hd-ticket/39071