Skip to content

fix: filter to ignore system generated cr / dr reconciliation journals on customer ledger summary #47683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

fix: filter to ignore system generated cr / dr reconciliation journals on customer ledger summary #47683

wants to merge 5 commits into from

Conversation

debinnn
Copy link
Contributor

@debinnn debinnn commented May 22, 2025

image

@debinnn debinnn requested a review from ruthra-kumar as a code owner May 22, 2025 10:06
ljain112
ljain112 reviewed May 22, 2025
View reviewed changes
erpnext/accounts/report/customer_ledger_summary/customer_ledger_summary.py Outdated
if self.filters.get("ignore_cr_dr_notes"):
system_generated_cr_dr_journals = frappe.db.get_all(
"Journal Entry",
filters={
Copy link
Collaborator

@ljain112 ljain112 May 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be handeled in "get_gl_entries" function where condition for gl_entries are prepared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljain112 ljain112 ljain112 left review comments

@ruthra-kumar ruthra-kumar Awaiting requested review from ruthra-kumar ruthra-kumar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@debinnn @ljain112