fix: incorrect valuation rate due to positive qty #47686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khushi8112
added
backport version-15-hotfix
backport version-14-hotfix
mergify bot
pushed a commit
that referenced
this pull request
May 22, 2025
(cherry picked from commit 6ed97b5)
mergify bot
pushed a commit
that referenced
this pull request
May 22, 2025
(cherry picked from commit 6ed97b5)
This was referenced May 22, 2025
khushi8112
added a commit
that referenced
this pull request
May 22, 2025
…47688) fix: incorrect valuation rate due to positive qty (#47686) (cherry picked from commit 6ed97b5) Co-authored-by: Khushi Rawat <[email protected]>
khushi8112
added a commit
that referenced
this pull request
May 22, 2025
…47687) fix: incorrect valuation rate due to positive qty (#47686) (cherry picked from commit 6ed97b5) Co-authored-by: Khushi Rawat <[email protected]>
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 27, 2025
## [14.85.10](v14.85.9...v14.85.10) (2025-05-27) ### Bug Fixes * incorrect status in the serial no ([#47740](#47740)) ([d37b12f](d37b12f)) * incorrect valuation rate due to positive qty (backport [#47686](#47686)) ([#47687](#47687)) ([d5d4b3a](d5d4b3a)) * only include advances within the tcs period ([43aeff3](43aeff3)) * patch to rename group_by filter in custom reports (backport [#47709](#47709)) ([#47729](#47729)) ([70bcfb4](70bcfb4)) * rate changing while making PR (negative discount) (backport [#40539](#40539)) ([#47735](#47735)) ([70e6ea6](70e6ea6)) * remove public access to list items (backport [#45838](#45838)) ([5d9be73](5d9be73)) * skip last purchase rate for free item (backport [#47693](#47693)) ([#47695](#47695)) ([1f1cb33](1f1cb33)) * validation message format (backport [#47542](#47542)) ([#47549](#47549)) ([792f3af](792f3af))
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 27, 2025
# [15.63.0](v15.62.0...v15.63.0) (2025-05-27) ### Bug Fixes * absence of rounding causing discrepancy in the valuation rate calculation (backport [#47700](#47700)) ([#47711](#47711)) ([f41bcc6](f41bcc6)) * add no_copy for lost reasons ([db97dbd](db97dbd)) * create Quality Inspection button not showing (backport [#47746](#47746)) ([#47750](#47750)) ([60dfe36](60dfe36)) * display stock value in currency format in chart warehouse wise stock value ([ba009f4](ba009f4)) * do not update same field twice ([63ba27e](63ba27e)) * exchange rate not being fetched when creating supplier quotation from MR ([2c22615](2c22615)) * filter of item for manufacture type material request (backport [#47712](#47712)) ([#47717](#47717)) ([2961e59](2961e59)) * handle multiselect filters for tree doctypes in Customer Ledger Summary Report ([f783bf6](f783bf6)) * Headline rendered twice on first save ([f94a14c](f94a14c)) * include rejected amount in PI/PR overbilling validation logic ([#47572](#47572)) ([cd1c10a](cd1c10a)) * incorrect inventory dimension for material transfer (backport [#47592](#47592)) ([#47644](#47644)) ([9a78283](9a78283)) * incorrect valuation rate due to positive qty (backport [#47686](#47686)) ([#47688](#47688)) ([62aa1cd](62aa1cd)) * linter ([c44493f](c44493f)) * Linter (due to conflicts resolved on gh) ([37f4cf5](37f4cf5)) * Linters ([91e167f](91e167f)) * made changes specifically for value adjustment entry ([74e29f1](74e29f1)) * Merge conflicts ([3deb11e](3deb11e)) * only include advances within the tcs period ([a2f5975](a2f5975)) * party account based on party type's account type ([d3d22f6](d3d22f6)) * patch to rename group_by filter in custom reports (backport [#47709](#47709)) ([#47730](#47730)) ([a137944](a137944)) * patch to set status cancelled for already cancelled pos invoices (backport [#47725](#47725)) ([#47759](#47759)) ([4fd1af2](4fd1af2)) * **portal:** User cannot create 0 qty SQ from RFQ ([f95a3f5](f95a3f5)) * pos invoice status not updating on cancel (backport [#47556](#47556)) ([#47657](#47657)) ([db318a4](db318a4)) * prettier ([0f22646](0f22646)) * prettier ([2c8db09](2c8db09)) * Relabel unit price settings for more clarity ([8891f46](8891f46)) * setting paid amount to 0 when is_paid is unchecked in purchase invoice ([895231a](895231a)) * show general ledger in doc currency in Process Statement Of Accounts ([b3cbbf2](b3cbbf2)) * skip drop ship items (backport [#47670](#47670)) ([#47718](#47718)) ([e058885](e058885)) * skip last purchase rate for free item (backport [#47693](#47693)) ([#47696](#47696)) ([f17b7b5](f17b7b5)) * space ([fe78bb6](fe78bb6)) * space ([194e41a](194e41a)) * translate_pos_buttons ([01b0d10](01b0d10)) * Treat rows as Unit Price rows only until the qty is 0 ([d963601](d963601)) * typo in TREE_DOCTYPES list "Terrirtory" should be "Territory" ([3d2d1ba](3d2d1ba)) * updated value after depreciation after value adjustment ([8ed6e98](8ed6e98)) * use pypika object `LiteralValue` for adding match conditions ([fb2df77](fb2df77)) ### Features * add validation for Item Tax Template on rate change ([92d5e91](92d5e91)) * Unit Price Contract ([33366fc](33366fc)) * Unit Price Items in Buying (RFQ, SQ, PO) ([f8fa775](f8fa775))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the get_warehouse_details call within the Asset Capitalization doctype's client script, the quantity was being passed as a positive value using qty: flt(item.stock_qty). This caused an issue where incoming rates were fetched incorrectly.
Before
REC-20250522152232.mp4
After
REC-20250522155333.mp4