Skip to content

Fix invalid input handling in calculator #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix invalid input handling in calculator #659

wants to merge 1 commit into from

Conversation

MohammadAshmir786
Copy link

@MohammadAshmir786 MohammadAshmir786 commented Apr 13, 2025 •
edited
Loading

Checklist:

Summary of changes:

  • Fixed invalid input handling in the calculator.
  • Updated the event handlers to show "Invalid Input" on incorrect formulas.

@MohammadAshmir786 MohammadAshmir786 requested a review from a team as a code owner April 13, 2025 01:55
@ilenia-magoni
Copy link
Contributor

does your PR solve the issue or not?

@MohammadAshmir786
Copy link
Author

does your PR solve the issue or not?

Thank you for reviewing my pull request. Yes, this PR addresses the issue described in #472.

Specifically,

  • it fixes the invalid input handling in the JavaScript calculator by updating the event handlers to display "Invalid Input" when incorrect formulas are entered.
  • The changes have been tested to ensure they resolve the issue effectively.

Please let me know if you have any further feedback or suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MohammadAshmir786 @ilenia-magoni