Skip to content

[URH-46] 테스트환경 기능 업데이트 #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 5, 2024
Merged

[URH-46] 테스트환경 기능 업데이트 #40

merged 2 commits into from
Aug 5, 2024

Conversation

foresec
Copy link
Collaborator

@foresec foresec commented Aug 4, 2024 •
edited
Loading

👾 Pull Request

  • 상태: 기능 업데이트

1️⃣ Spec

  • npm test를 pre-commit에 추가하며 커밋 전에 test를 진행합니다

2️⃣ 변경 사항

  • useDetectInactivity.test.ts파일에서 발생한 테스트 오류를 함께 수정했습니다.

3️⃣ 예시 코드

4️⃣ 관련 문서 (선택 사항)

@Choozii Choozii requested a review from bicochan August 4, 2024 15:12
suhyeoonn
suhyeoonn approved these changes Aug 4, 2024
View reviewed changes
Copy link
Contributor

@suhyeoonn suhyeoonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bicochan
bicochan approved these changes Aug 4, 2024
View reviewed changes
Copy link
Member

@bicochan bicochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다 소현 님!👍🏻

jeongbaebang
jeongbaebang approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@jeongbaebang jeongbaebang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@foresec foresec merged commit c400c93 into master Aug 5, 2024
8 checks passed
@foresec foresec deleted the URH-46/husky-setting branch August 5, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suhyeoonn suhyeoonn suhyeoonn approved these changes

@bicochan bicochan bicochan approved these changes

@jeongbaebang jeongbaebang jeongbaebang approved these changes

@Choozii Choozii Awaiting requested review from Choozii

Assignees

@foresec foresec

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@foresec @suhyeoonn @bicochan @jeongbaebang