Allow file-like objects to be passed as attachments #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh yes definitely, this is what I needed before I could even start to use ogmios. |
| data = attachment['data'].read() | ||
| else: | ||
| fpath = attachment['path'] | ||
| full_path = os.path.join(fpath) |
There was a problem hiding this comment.
I'm not sure to understand what you're trying to do here? os.path.join(x) is a no-op as far as I know (I could be wrong). Did you mean os.path.abspath(x)?
There was a problem hiding this comment.
That's actually from you. I thought so as well but figured that you knew something I didn't. See 2ea20c8.
There was a problem hiding this comment.
Yep. That's a mistake from my side. Can you do another commit "fix antoine's shit" where you change this to os.path.abspath()? Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.