Skip to content

[master] Fixed Credentials Search #2455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 2, 2025
Merged

[master] Fixed Credentials Search #2455

merged 6 commits into from
Jun 2, 2025

Conversation

grolu
Copy link
Contributor

@grolu grolu commented May 21, 2025

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fixed Credentials Search

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels May 21, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 21, 2025
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 21, 2025
petersutter
petersutter reviewed May 21, 2025
View reviewed changes
@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else and removed size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels May 21, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 21, 2025
petersutter
petersutter reviewed May 22, 2025
View reviewed changes
@gardener-robot
Copy link

@klocke-io, @holgerkoser You have pull request review open invite, please check

@grolu
Proposal to allow passing composable from parent component to rows wi…
4d7c942 
…thout loosing reactivity even if cell gets reused
@gardener-robot gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) and removed size/l Size of pull request is large (see gardener-robot robot/bots/size.py) labels May 27, 2025
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 27, 2025
petersutter
petersutter reviewed May 27, 2025
View reviewed changes
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 28, 2025
petersutter
petersutter reviewed May 28, 2025
View reviewed changes
frontend/src/views/GCredentials.vue Outdated
Comment on lines 123 to 128
:binding="item.binding"
:credential-usage-count="item.credentialUsageCount"
:is-shared-credential="item.isSharedCredential"
:is-orphaned-credential="item.isOrphanedCredential"
:credential-namespace="item.credentialNamespace"
:credential="item.credential"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:binding="item.binding"
:credential-usage-count="item.credentialUsageCount"
:is-shared-credential="item.isSharedCredential"
:is-orphaned-credential="item.isOrphanedCredential"
:credential-namespace="item.credentialNamespace"
:credential="item.credential"

petersutter
petersutter approved these changes May 28, 2025
View reviewed changes
Copy link
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label May 28, 2025
@gardener-robot gardener-robot removed needs/review Needs review needs/second-opinion Needs second review by someone else labels May 28, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 28, 2025
@gardener-robot gardener-robot added needs/second-opinion Needs second review by someone else and removed reviewed/lgtm Has approval for merging labels May 28, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 28, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 2, 2025
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 2, 2025
@grolu grolu added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 2, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 2, 2025
@grolu grolu merged commit ba08ede into master Jun 2, 2025
11 checks passed
@grolu grolu deleted the bug/fix_credential_search_master branch June 2, 2025 09:19
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petersutter petersutter petersutter approved these changes

@holgerkoser holgerkoser Awaiting requested review from holgerkoser holgerkoser is a code owner

@klocke-io klocke-io Awaiting requested review from klocke-io klocke-io is a code owner

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/second-opinion Needs second review by someone else size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@grolu @gardener-robot @petersutter @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3