Continue SGB border #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR gbdev#70 ended with different suggested changes stomping on one another. Finish the last few tasks mentioned in that PR's discussion. - fix a comma splice - explain why wait 4 frames - emphasize why the screen must be on - use line comments (;) instead of C block comments (/*...*/) - transform detection code into a subroutine to eliminate `.init` - rewrite detection code to use a busy wait loop instead of vblank interrupt - let the lines settle after each read in case A+Right held on DMG - store the detection result to a variable - Remove mention of use of palettes 1-3 and 7
avivace
approved these changes
Oct 17, 2023
|
Thanks a lot @pinobatch , I'll start merging it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #70 ended with different suggested changes stomping on one another. Finish the last few tasks mentioned in that PR's discussion.
;) instead of C block comments (/*...*/).init