Skip to content

[unifi] update unifi to 7.4.162 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 25, 2023
Merged

Conversation

si458
Copy link

@si458 si458 commented Jul 25, 2023

Description of the change

Benefits

Possible drawbacks

Applicable issues

  • fixes #

Additional information

Checklist

  • Title of the PR starts with chart name (e.g. [home-assistant])
  • Chart version bumped in Chart.yaml according to semver.
  • Chart artifacthub.io/changes changelog annotation has been updated in Chart.yaml. See Artifact Hub documentation for more info.
  • Variables have been documented in the values.yaml file.

@si458 si458 requested a review from funkypenguin as a code owner July 25, 2023 22:08
@si458 si458 changed the title update unifi to 7.4.162 [unifi] update unifi to 7.4.162 Jul 25, 2023
Copy link

@funkypenguin funkypenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the way to do this is to add multiple entries, so that there's a history of changes in artifacthub.. so something like this:

- kind: changed
  description: did something
- kind: changed
  description: did something else...

Copy link

@funkypenguin funkypenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @si458 , just one minor change on the artifacthub metadata please :)

@si458
Copy link
Author

si458 commented Jul 25, 2023

I think the way to do this is to add multiple entries, so that there's a history of changes in artifacthub.. so something like this:

- kind: changed
  description: did something
- kind: changed
  description: did something else...

should be ok 👍 sorry new to the update process!

EDIT: NO I WAS RIGHT THE FIRST TIME AROUND!
https://blog.artifacthub.io/blog/changelogs/
The changes only need to include those for the current version. Artifact Hub builds the multi-release changelog from changes for each version

This reverts commit 45b9030.
@funkypenguin funkypenguin merged commit 50d5084 into geek-cookbook:main Jul 25, 2023
@si458 si458 deleted the patch-1 branch July 25, 2023 22:31
@si458
Copy link
Author

si458 commented Jul 25, 2023

oh dear the release failed its guthub action! 😱

@funkypenguin
Copy link

Oof, looks like I need to tidy up these actions! Sorry about that, I'll take a look today...

@si458
Copy link
Author

si458 commented Jul 25, 2023

Oof, looks like I need to tidy up these actions! Sorry about that, I'll take a look today...

no rush! im just building my cluster of apps, and alot of your helm charts are perfect! they just need the app versions updating!

EDIT: found these which might help
https://github.com/shaybentk/helm-docs-action
https://github.com/norwoodj/helm-docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants