-
-
Notifications
You must be signed in to change notification settings - Fork 288
add bbox support for CSV and GeoJSON feature providers #2058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for these improvements! 👍🏽
Please check some minor comments.
tests/api/test_itemtypes.py
Outdated
assert len(features['features']) == 1 | ||
|
||
links = features['links'] | ||
assert len(links) == 6 | ||
assert '/collections/obs/items?f=json&limit=1&bbox=-180,90,180,90' in \ | ||
assert '/collections/obs/items?f=json&limit=1' in \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the bbox tests are removed from here, does it mean we are going to create separate tests for each features (and records) provider?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this test because of previous behaviour of WxS (if property is null, it doesn't evaluate to true n a query/match). Looking at OAFeat Req 24C, I've updated this to true, hence restorng the existing behaviour in tests/api/test_itemtypes.py
(the remaining changes being updating the miny value in the request and the resulting links).
Overview
This PR adds bbox support for CSV and GeoJSON providers using Shapely (which is already part of the core dependency chain).
Related Issue / discussion
Somewhat related to #2000
Additional information
None
Dependency policy (RFC2)
Updates to public demo
Contributions and licensing
(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)